Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add AtServerEvent interface and AtSignPKChangedEvent class. Enables better reset handling #773

Merged
merged 11 commits into from
Feb 25, 2025
Merged

feat: Add AtServerEvent interface and AtSignPKChangedEvent class. Enables better reset handling #773

merged 11 commits into from
Feb 25, 2025

Conversation

gkc
Copy link
Contributor

@gkc gkc commented Feb 25, 2025 •
edited
Loading

- What I did

  • feat: add AtServerEvent interface and AtSignPKChangedEvent class, plus unit tests
    • These are being added to at_commons because both atServer and atClient need them
    • Why an interface and one implementation? To allow for other types of atServer events in the future.
    • Why does AtServerEvent have a category? To allow atServer implementations to create events which are specific to that implementation rather than core to atProtocol
  • Part of resolution of https://github.com/atsign-foundation/operations/issues/186
  • feat: have the new atSignPKChangedEvent constructor use the new toAtsign function from the new AtsignString extension. Added unit tests to cover.
  • chore: fix all lint warnings following change of minimum required SDK version from 2.15.0 to 3.0.0
  • docs: updated CHANGELOG

- How I did it
See commits

- How to verify it
Tests pass

gkc added 11 commits February 24, 2025 13:03
@gkc
feat: add AtServerEvent interface and AtSignPKChangedEvent class
10a5392
@gkc
Merge remote-tracking branch 'origin/trunk' into enable-better-reset-…
2987091 
…handling

# Conflicts:
#	packages/at_commons/pubspec.yaml
@gkc
build: update version to 5.3.0
67dce8f
@gkc
build: update CHANGELOG
a127de6
@gkc
build: change version back to 5.2.0 since 5.2.0 has not yet been publ…
7d7ff31 
…ished
@gkc
feat: have atSignPKChangedEvent constructor use the new toAtsign func…
5cbf425 
…tion from the new AtsignString extension. Add unit tests to cover.
@gkc
chore: dart format
a2b7911
@gkc
chore: fix all lint warnings following change of minimum required SDK…
884f25e 
… version from 2.15.0 to 3.0.0
@gkc
feat: added AtConstants.atServerReservedNamespace
9ee4890
@gkc
chore: better fix for a particular lint-related change
428bd3b
@gkc
docs: Added doc for AtServerEvent interface
6b7b510
@gkc gkc requested a review from cpswan February 25, 2025 11:29
@gkc gkc mentioned this pull request Feb 25, 2025
Merged
@gkc gkc merged commit e609328 into trunk Feb 25, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpswan cpswan cpswan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gkc @cpswan